Event’s data update Aug 2024 for the landing page of events.wordpress.org #1359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkevan
approved these changes
Aug 13, 2024
| <!-- /wp:paragraph --></div> | ||
| <!-- /wp:group --></div> | ||
| <!-- /wp:column --> | ||
|
|
||
| <!-- wp:column {"width":"33.33%","fontSize":"medium","fontFamily":"eb-garamond"} --> | ||
| <div class="wp-block-column has-eb-garamond-font-family has-medium-font-size" style="flex-basis:33.33%"><!-- wp:group {"style":{"border":{"radius":"2px","width":"1px"},"spacing":{"padding":{"left":"var:preset|spacing|30","top":"var:preset|spacing|20","bottom":"var:preset|spacing|20"}}},"borderColor":"light-grey-1","layout":{"type":"constrained"}} --> | ||
| <div class="wp-block-group has-border-color has-light-grey-1-border-color" style="border-width:1px;border-radius:2px;padding-top:var(--wp--preset--spacing--20);padding-bottom:var(--wp--preset--spacing--20);padding-left:var(--wp--preset--spacing--30)"><!-- wp:paragraph {"style":{"layout":{"selfStretch":"fit","flexSize":null},"elements":{"link":{"color":{"text":"var:preset|color|charcoal-0"}}}},"textColor":"charcoal-0","fontSize":"heading-6"} --> | ||
| <p class="has-charcoal-0-color has-text-color has-link-color has-heading-6-font-size">540,537 participants</p> | ||
| <p class="has-charcoal-0-color has-text-color has-link-color has-heading-6-font-size">+500,000 participants</p> |
There was a problem hiding this comment.
Thanks for the Pull Request!
One minor thing, I am more familiar with adding the '+' after the number, like so, "500,000+". Is there a particular reason why it's added before the number?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Event’s data update Aug 2024 for the landing page of events.wordpress.org
The Events Data in the landing page events.wordpress.org needed to be updated as it was shown Events data of 2023.
Props @retrofox
Screenshots
How to test the changes in this Pull Request: