Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix always show "the link you followed has expired" error page #1321

Merged
merged 3 commits into from
May 20, 2024

Conversation

renintw
Copy link
Contributor

@renintw renintw commented May 20, 2024

In #1051, the logic about save_post here causes the "The link you followed has expired" message to always appear when saving a post. Therefore in this PR, only retain the part in #1051 that adds a new "Needs follow-up" status for payments and remove else for further fixes.

image

@renintw renintw closed this May 20, 2024
@renintw renintw force-pushed the fix/always-show-the-link-you-followed-has-expired branch from 484386d to e21ab60 Compare May 20, 2024 18:16
@renintw renintw changed the title Fix always show the link you followed has expired Fix always show "the link you followed has expired" error page May 20, 2024
@renintw renintw reopened this May 20, 2024
@renintw renintw force-pushed the fix/always-show-the-link-you-followed-has-expired branch from c95dfa4 to 11be950 Compare May 20, 2024 19:26
renintw added 3 commits May 21, 2024 04:33
In last commit, the "extend the notes field for vendor payments" causes the "The link you followed has expired" message to always appear when saving a post.

Therefore here only retains the part related to adding a new "Needs follow-up" status for payments and remove else.
@renintw renintw force-pushed the fix/always-show-the-link-you-followed-has-expired branch from bc10f65 to 663588c Compare May 20, 2024 19:35
@renintw renintw self-assigned this May 20, 2024
@renintw renintw merged commit 4fcecb6 into production May 20, 2024
3 checks passed
@renintw renintw deleted the fix/always-show-the-link-you-followed-has-expired branch May 20, 2024 19:51
renintw added a commit that referenced this pull request May 23, 2024
renintw added a commit that referenced this pull request May 23, 2024
* Revert "Fix always show "the link you followed has expired" error page (#1321)"

This reverts commit 4fcecb6.

* Revert "New reimbursement request and vendor payments status and notes functionality (#1051)"

This reverts commit e21ab60.

* add new wcb-needs-followup status for payments

* add new wcb-needs-followup status to network payments views

* take new wcb-pending-approval status into consideration when doing the overdue vendor payments list

---------

Co-authored-by: Timi Wahalahti <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

It always show "the link you followed has expired" error page after saving a post
1 participant