Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jetpack Tweaks: Enable jetpack forms package #1074

Merged
merged 1 commit into from
Oct 2, 2023
Merged

Conversation

ryelle
Copy link
Contributor

@ryelle ryelle commented Oct 2, 2023

Somehow, the contact forms stopped working on WordCamp.org— the form wrapper is rendered, but the fields are not.

Screenshot 2023-10-02 at 2 01 34 PM

Removing the local override to use the classic "grunion" forms fixes the issue, so forms are now using the "form package". This was originally in place to keep an accessibility fix, so that has also been updated to work with the form package version.

Follow up to #874
See https://wordpress.slack.com/archives/C08M59V3P/p1696266125242069

How to test the changes in this Pull Request:

  1. View a contact form
  2. It should work ✅
  3. View a field with either checkboxes or radio buttons, using default form style
  4. It should be wrapped in a fieldset

Will merge when tests pass to fix the forms on production ASAP.

@ryelle ryelle self-assigned this Oct 2, 2023
@ryelle ryelle added the [Component] Jetpack Customizations to Jetpack label Oct 2, 2023
@ryelle ryelle merged commit 5849491 into production Oct 2, 2023
3 checks passed
@ryelle ryelle deleted the fix/contact-forms branch October 2, 2023 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Component] Jetpack Customizations to Jetpack
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant