-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the slack bot title. #1066
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍🏻
$title = 'New WordCamp scheduled!!!'; | ||
$url = wp_parse_url( filter_var( $wordcamp_url, FILTER_VALIDATE_URL ) ); | ||
$tld = get_top_level_domain(); | ||
$is_event = "events.wordpress.$tld" === $url['host']; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be nice to turn this into a helper function where you could pass in a URL and get back wordcamp
or next-gen
. That'd be a good compliment to is_wordcamp_type()
.
We can always do that in future though, not a big deal if you don't want to for this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about this: b158437?
I chose to keep the language specific to events because i don't think we need expose the type slugs in the plugins.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That looks good 👍🏻
This PR updates the title and description that posts to slack when a new wordcamp is scheduled.
See https://wordpress.slack.com/archives/C02RQC7RN/p1695367159820359?thread_ts=1695355705.699669&cid=C02RQC7RN
Props nao, devinmaeztri, iandunn