Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show empty tickets with "sold out" message #1064

Merged
merged 2 commits into from
Oct 10, 2023

Conversation

timiwahalahti
Copy link
Collaborator

Currently sold-out tickets are hidden from the tickets page.

Showing the empty, sold-out, tickets helps to avoid confusion if the camp has several types of tickets (e.g., General Admission, Micro-sponsorship, etc) and the General Admission ticket sells out. If the General Admission ticket was hidden, some users may mistakenly think that the Micro-sponsorship ticket is the "normal" ticket, even though it costs several hundred dollars. Since we value keeping regular tickets accessible by as many people as possible, we don't want anyone getting the impression that WordCamps are expensive to attend.

Fixes #573

Props @hlashbrooke

Screenshots

CleanShot 2023-09-22 at 00 39 10@2x

How to test the changes in this Pull Request:

  1. Go to a WordCamp site
  2. Modify a ticket type to have 0 remaining
  3. Ensure you have another ticket type that has tickets left
  4. Visit the tickets page

Copy link
Member

@iandunn iandunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍🏻

@iandunn iandunn merged commit c9e206f into WordPress:production Oct 10, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Component] CampTix Including addons
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CampTix: Poor UX when one ticket type is sold out
2 participants