-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include sharable link in "favorite sessions" email #1056
Conversation
Lint errors (phpcs) are coming from rule that I don't get.
|
For some reason PHPCS is treating the I can see two ways of this being used in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: I timeboxed some time to address the issue where PHPCS was mistakenly identifying anonymous functions as declaration functions. Found that: 1. The |
The "favorite sessions" email includes the sessions the user chose, it'd be helpful to include the link, so that they can easily apply those sessions to their phone or other device, and so that they can easily get a much better view of their personalized schedule on the website.
This PR adds that link to that email.
For ease, let's get the schedule page by slug. This way we do not need to pass the page ID just for this, but we neither blindly trust the input sent to REST API as a URL that belongs to the WordCamp site.
Fixes #186
Props @iandunn
Screenshots
How to test the changes in this Pull Request: