WIP: Add multisite support for admin page #94
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vishalkakadiya
changed the title
spacedmonkey
reviewed
Mar 2, 2023
| 'settings.php', | ||
| __( 'Plugin Check', 'plugin-check' ), | ||
| __( 'Plugin Check', 'plugin-check' ), | ||
| 'activate_plugins', |
There was a problem hiding this comment.
Suggested change
| 'activate_plugins', | |
| 'manage_network_plugins', |
| $hook = add_management_page( | ||
| __( 'Plugin Check', 'plugin-check' ), | ||
| __( 'Plugin Check', 'plugin-check' ), | ||
| 'activate_plugins', |
There was a problem hiding this comment.
Suggested change
| 'activate_plugins', | |
| 'manage_network_plugins', |
|
I would look into this line as well |
|
Should this button be styled? |
|
I would consider adding a property to the class to stop repeated code. See spacedmonkey@f4d2244 |
|
Closing this one for now as it's stale and has conflicts. It can be reopened / forked when the issue gets picked up again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds multisite support for admin page
Closes #64