Fix PHPCS checks on unwritable filesystems. #813
Conversation
In #744 a call to setConfigData() was added which has the `$temporary` parameter set to the default, which is `true`. This causes PHPCS to attempt to write to `wp-content/plugins/plugin-check-trunk/vendor/squizlabs/php_codesniffer/CodeSniffer.conf` which is unwritable on immutable filesystems, causing the entire plugin check to abort.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
cc @swissspidy I've not exactly tested this, I have tested that it allows an unwritable config file not to abort, but I haven't actually tested that it doesn't break the functionality. This has been deployed to WordPress.org. |
|
@ernilambar Does your custom addon still work with that? I thought the config needs to be written so that an addon with custom PHPCS checks works as expected. |
|
Yes. Addon is working like before with third parameter set to true. |
In #744 a call to setConfigData() was added which has the
$tempparameter set to the default, which istrue.This causes PHPCS to attempt to write the given config to disk.
The default config location is..
wp-content/plugins/plugin-check/vendor/squizlabs/php_codesniffer/CodeSniffer.confIf WordPress is installed on an immutable filesystem (Such as WordPress.org) this causes the entire plugin check to abort.