Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update message for mismatched stable tag to make it more clear #666

Merged
merged 2 commits into from
Sep 26, 2024

Conversation

ernilambar
Copy link
Member

@ernilambar ernilambar commented Sep 26, 2024

Earlier:

The Stable Tag in your readme file does not match the version in your main plugin file. Your Stable Tag is meant to be the stable version of your plugin, not of WordPress. For your plugin to be properly downloaded from WordPress.org, those values need to be the same. If they're out of sync, your users won't get the right version of your code.

Now:

Mismatched Stable Tag: 1.0.0 != 1.0.1. The Stable Tag in your readme file does not match the version in your main plugin file. Your Stable Tag is meant to be the stable version of your plugin, not of WordPress. For your plugin to be properly downloaded from WordPress.org, those values need to be the same. If they're out of sync, your users won't get the right version of your code.

Note: I have also added return inside if ( 'trunk' === $stable_tag ) because we were not supposed to go for comparison if the value is trunk. Since task and the issue is quite related and in the same place, I have kept in the same PR.

Edit: On the second thought, I will create separate PR for that issue as it is breaking other several unit tests.

Screenshot:
Screenshot 2024-09-26 at 11 25 10 AM

@ernilambar ernilambar marked this pull request as ready for review September 26, 2024 05:59
Copy link

github-actions bot commented Sep 26, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: ernilambar <[email protected]>
Co-authored-by: swissspidy <[email protected]>
Co-authored-by: davidperezgar <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@davidperezgar davidperezgar merged commit 3d2f035 into trunk Sep 26, 2024
31 checks passed
@davidperezgar davidperezgar deleted the update-mismatched-stable-tag-message branch September 26, 2024 15:16
@ernilambar ernilambar added this to the 1.2.0 milestone Sep 26, 2024
@ernilambar ernilambar added [Type] Enhancement A suggestion for improvement of an existing feature [Team] Plugin Review Issues owned by Plugin Review Team labels Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Team] Plugin Review Issues owned by Plugin Review Team [Type] Enhancement A suggestion for improvement of an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants