Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning for invalid Tested up to value #613

Merged
merged 2 commits into from
Sep 6, 2024
Merged

Conversation

ernilambar
Copy link
Member

Fixes #609

@ernilambar ernilambar changed the title Warn for invalid tested up to value Warning for invalid Tested up to value Sep 6, 2024
@ernilambar ernilambar marked this pull request as ready for review September 6, 2024 06:22
Copy link

github-actions bot commented Sep 6, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: ernilambar <[email protected]>
Co-authored-by: davidperezgar <[email protected]>
Co-authored-by: swissspidy <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@swissspidy
Copy link
Member

Could we add tests for this? :-)

  • Latest WP version
  • Latest +1
  • Latest +2

@ernilambar
Copy link
Member Author

@swissspidy I was thinking about using similar test like test_run_with_errors_parser_warnings_with_custom_set_transient_version(). Should we add three separate test plugins for this? Or is there any better approach?

@swissspidy
Copy link
Member

Mocking the transient makes sense to me. We have way too many test plugins already 😄

@ernilambar
Copy link
Member Author

Unit test added.

@swissspidy swissspidy added the [Type] Enhancement A suggestion for improvement of an existing feature label Sep 6, 2024
@swissspidy swissspidy added this to the 1.2.0 milestone Sep 6, 2024
@swissspidy swissspidy merged commit 75be00e into trunk Sep 6, 2024
23 checks passed
@swissspidy swissspidy deleted the 609-future-tested-up-to branch September 6, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Enhancement A suggestion for improvement of an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warn if Tested up to value in readme exceeds the released version of WP
3 participants