Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow runtime initialization even when only addon checks are requested #612

Merged
merged 3 commits into from
Sep 6, 2024

Conversation

felixarntz
Copy link
Member

This should fix the 3rd problem outlined in #597 (comment). Also see explanation of the approach.

Note that this will only make sense to be tested in combination with #608.

@felixarntz felixarntz added the [Type] Bug An existing feature is broken label Sep 5, 2024
Copy link

github-actions bot commented Sep 5, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: felixarntz <[email protected]>
Co-authored-by: swissspidy <[email protected]>
Co-authored-by: ernilambar <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@felixarntz
Copy link
Member Author

@swissspidy Once #608 is merged, let's give this one a try. At the very least, it should fix part of the remaining problem with addon runtime checks.

@swissspidy
Copy link
Member

Could you give it a try to implement a Behat test that runs two runtime checks, one from the addon and one built-in one?

Doesn't work. When I use e.g. --checks=non_blocking_scripts,example_runtime I still get Error: Check with the slug "example_runtime" does not exist..

@felixarntz
Copy link
Member Author

felixarntz commented Sep 5, 2024

@swissspidy You approved this, but I wonder whether we should keep it open until we figured out what else is missing. Just want to make sure we're not introducing something here that's wrong. WDYT?

Maybe we should reactivate those failing Behat tests in this PR and work towards making them pass.

@swissspidy swissspidy added this to the 1.2.0 milestone Sep 5, 2024
@swissspidy
Copy link
Member

Whether we do smaller PRs or try to fix everything in this PR, either works for me

@felixarntz
Copy link
Member Author

That's fair. I guess this fixes at least part of the problem, so we could already merge it.

@swissspidy swissspidy merged commit 9d72214 into trunk Sep 6, 2024
23 checks passed
@swissspidy swissspidy deleted the fix/early-check-retrieval branch September 6, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug An existing feature is broken
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants