-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow runtime initialization even when only addon checks are requested #612
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
@swissspidy Once #608 is merged, let's give this one a try. At the very least, it should fix part of the remaining problem with addon runtime checks. |
Doesn't work. When I use e.g. |
@swissspidy You approved this, but I wonder whether we should keep it open until we figured out what else is missing. Just want to make sure we're not introducing something here that's wrong. WDYT? Maybe we should reactivate those failing Behat tests in this PR and work towards making them pass. |
Whether we do smaller PRs or try to fix everything in this PR, either works for me |
That's fair. I guess this fixes at least part of the problem, so we could already merge it. |
This should fix the 3rd problem outlined in #597 (comment). Also see explanation of the approach.
Note that this will only make sense to be tested in combination with #608.