-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance list-checks command #379
Enhance list-checks command #379
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ernilambar I think the ideas here make sense, however the implementation can be simplified.
Updates:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ernilambar The production code changes look great to me now. However it looks like there are some Behat test failures, see https://github.com/WordPress/plugin-check/actions/runs/7470848675/job/20330167511?pr=379.
cc @swissspidy
Those Behat failures are unrelated and fixed in #381 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's merge #381 and then refresh this branch to make sure the failures are gone :)
Thank you for the PR!
Refactor list-checks command with improvements.
get_checks()
ofDefault_Check_Repository
by default does not return experimental checks. This PR fix that issue for returing all checks with parameterDefault_Check_Repository::TYPE_ALL | Default_Check_Repository::INCLUDE_EXPERIMENTAL
.--categories
argument is added to filter checks by categories.--stability
argument is added to filter checks by stability. Takes eitherstable
orexperimental
.Output:
wp plugin list-checks --stability=stable
- Currently all checks will be displayed as we dont have experimental checks yet.wp plugin list-checks --categories=performance
wp plugin list-checks --categories=performance,general