Introduce check category labels #375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Now that #339 is merged we can use these in |
ernilambar
force-pushed
the
373-introduce-category-labels
branch
from
0dfcc76
to
d99ec6f
Compare
PR updated. |
swissspidy
approved these changes
Jan 5, 2024
felixarntz
reviewed
Jan 5, 2024
There was a problem hiding this comment.
@ernilambar Thanks for the PR, this looks great!
Two non-blocking nit-picks, my only crucial feedback is to not escape the strings too early.
|
PR updated. |
felixarntz
approved these changes
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #373