Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix plugin name from readme in Trademarks check #354

Merged
merged 1 commit into from
Dec 21, 2023
Merged

Fix plugin name from readme in Trademarks check #354

merged 1 commit into from
Dec 21, 2023

Conversation

ernilambar
Copy link
Member

When checking plugin name from readme, we are using this /===(.*)===/i regex. So its matches will also include whitespace around the actual plugin name. This PR will omit that whitespace characters.

  • Updated Trademarks_Check
  • Updated Trademarks_Check_Tests to reflect this change

Before

before-this-pr

After

after-this-pr

cc: @swissspidy @felixarntz @mukeshpanchal27

mukeshpanchal27
mukeshpanchal27 approved these changes Dec 21, 2023
View reviewed changes
Copy link
Member

@mukeshpanchal27 mukeshpanchal27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch.

@mukeshpanchal27 mukeshpanchal27 merged commit 4ac0bce into WordPress:trunk Dec 21, 2023
25 checks passed
@ernilambar ernilambar deleted the fix-plugin-name-in-readme branch December 21, 2023 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mukeshpanchal27 mukeshpanchal27 mukeshpanchal27 approved these changes

@swissspidy swissspidy swissspidy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ernilambar @swissspidy @mukeshpanchal27