Implement Readme Parser #346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ernilambar
force-pushed
the
implement-readme-parser
branch
2 times, most recently
from
a2340ec
to
6606e6e
Compare
ernilambar
force-pushed
the
implement-readme-parser
branch
from
6606e6e
to
1ab89fd
Compare
ernilambar
force-pushed
the
implement-readme-parser
branch
from
eaca180
to
61d15ba
Compare
mukeshpanchal27
requested changes
Jan 2, 2024
There was a problem hiding this comment.
Thanks @ernilambar for the PR. Left some feedback for consideration.
ernilambar
force-pushed
the
implement-readme-parser
branch
2 times, most recently
from
3d39941
to
9df7611
Compare
felixarntz
approved these changes
Jan 2, 2024
There was a problem hiding this comment.
This looks great, thank you @ernilambar! Only a small recommendation regarding the filter name, but otherwise good to go from my perspective.
ernilambar
force-pushed
the
implement-readme-parser
branch
from
9df7611
to
f9b8d15
Compare
|
PR has been updated. |
There was a problem hiding this comment.
Thank you, @ernilambar, for the update. It's almost ready to go. I've left some final feedback for your consideration.
tests/phpunit/tests/Checker/Checks/Plugin_Readme_Check_Tests.php
Outdated
Show resolved
Hide resolved
mukeshpanchal27
approved these changes
Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #322
afragen/wordpress-plugin-readme-parseras dependencyPlugin_Readme_Checkmethods to use new Parser class.check_for_warningsmethod for other readme parser warnings.check_for_warningsmethod.