-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove default select option from dropdown #344
Conversation
Thanks @ernilambar for the PR. I like the idea to remove default empty selection. If we there is no plugin then it will show I value the input from @felixarntz and @joemcgill on this matter. |
0578994
to
4ed7d3d
Compare
Hmm, I'm not sure about this. The only benefit I could see here is if a site only has a single plugin and that's what you want to test. But otherwise I would find it an arbitrary choice to have the alphabetically first plugin pre-selected, so from that perspective I prefer the neutral default we have now. How about this?
I think that would be a good compromise that would address both concerns. I don't feel strongly about it though, curious to hear other perspectives. |
I personally like these suggestion. |
a19796f
to
cb4568a
Compare
PR updated as per the comment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update @ernilambar. Left nit-pick other then look good to me.
cb4568a
to
73ae270
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ernilambar!
Fixes #343