Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove default select option from dropdown #344

Merged
merged 1 commit into from
Dec 21, 2023

Conversation

ernilambar
Copy link
Member

Fixes #343

@ernilambar ernilambar changed the title Fix plugins dropdown Remove default select option from dropdown Dec 18, 2023
@mukeshpanchal27
Copy link
Member

Thanks @ernilambar for the PR. I like the idea to remove default empty selection. If we there is no plugin then it will show No plugins available. message.

I value the input from @felixarntz and @joemcgill on this matter.

@felixarntz
Copy link
Member

felixarntz commented Dec 20, 2023

Hmm, I'm not sure about this. The only benefit I could see here is if a site only has a single plugin and that's what you want to test. But otherwise I would find it an arbitrary choice to have the alphabetically first plugin pre-selected, so from that perspective I prefer the neutral default we have now.

How about this?

  • If there's one plugin, we only put that plugin there and have it pre-selected.
  • Otherwise, things remain as they are now.

I think that would be a good compromise that would address both concerns.

I don't feel strongly about it though, curious to hear other perspectives.

@mukeshpanchal27
Copy link
Member

How about this?

  • If there's one plugin, we only put that plugin there and have it pre-selected.
  • Otherwise, things remain as they are now.

I personally like these suggestion.

@ernilambar ernilambar force-pushed the 343-fix-dropdown branch 2 times, most recently from a19796f to cb4568a Compare December 21, 2023 09:37
@ernilambar
Copy link
Member Author

PR updated as per the comment.

Copy link
Member

@mukeshpanchal27 mukeshpanchal27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update @ernilambar. Left nit-pick other then look good to me.

templates/admin-page.php Outdated Show resolved Hide resolved
templates/admin-page.php Outdated Show resolved Hide resolved
Copy link
Member

@felixarntz felixarntz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ernilambar!

@felixarntz felixarntz merged commit 72f3eb3 into WordPress:trunk Dec 21, 2023
25 checks passed
@ernilambar ernilambar deleted the 343-fix-dropdown branch January 5, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove default select option from plugins dropdown
4 participants