Prevent rewrite flushes for runtime checks #334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swissspidy
requested review from
westonruter,
joemcgill,
felixarntz and
mukeshpanchal27
westonruter
reviewed
Dec 11, 2023
Co-authored-by: Weston Ruter <[email protected]>
felixarntz
approved these changes
Dec 11, 2023
westonruter
approved these changes
Dec 11, 2023
|
Thanks @swissspidy. Just miss to approve the PR last night. Great work. |
|
Thanks to everyone who fixed this small but important issue ;-). Good job! |
felixarntz
added a commit
that referenced
this pull request
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #330
To test:
.htaccessfile won't be empty.Cannot be tested with unit tests as there is no Apache with mod_rewrite in a testing environment, so it's not possible to verify
.htaccessmodifications in any way.