Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing @since annotation #320

Merged
merged 1 commit into from
Nov 7, 2023
Merged

Add missing @since annotation #320

merged 1 commit into from
Nov 7, 2023

Conversation

mukeshpanchal27
Copy link
Member

While working on #319, I noticed that some functions were missing the @since annotation. This PR will add those missing annotations to the functions.

@mukeshpanchal27 mukeshpanchal27 marked this pull request as ready for review November 7, 2023 09:52
felixarntz
felixarntz approved these changes Nov 7, 2023
View reviewed changes
Copy link
Member

@felixarntz felixarntz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mukeshpanchal27!

@felixarntz felixarntz merged commit 784e18d into trunk Nov 7, 2023
11 checks passed
@felixarntz felixarntz deleted the add/missing-since branch November 7, 2023 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixarntz felixarntz felixarntz approved these changes

@swissspidy swissspidy swissspidy approved these changes

@joemcgill joemcgill Awaiting requested review from joemcgill

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mukeshpanchal27 @swissspidy @felixarntz