CLI: Add --exclude-checks support
#318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swissspidy
added
[Type] Enhancement
felixarntz
reviewed
Nov 6, 2023
There was a problem hiding this comment.
@swissspidy Almost LGTM, only I think we should choose a consistent name for the new argument.
| @@ -62,6 +62,10 @@ public function __construct( Plugin_Context $plugin_context ) { | |||
| * [--checks=<checks>] | |||
| * : Only runs checks provided as an argument in comma-separated values, e.g. i18n_usage, late_escaping. Otherwise runs all checks. | |||
| * | |||
| * [--exclude-checks=<checks>] | |||
There was a problem hiding this comment.
You call this ignore-checks / ignore-slugs everywhere else in this PR. I don't feel strongly about either way, but we should go with a consistent term throughout. It makes sense that the parameter uses "checks" while the code uses "slugs", but I mean we should only use the term "ignore" or "exclude" throughout.
I personally prefer exclude-checks I think, but either way WFM.
There was a problem hiding this comment.
Makes sense, let's settle on exclude
swissspidy
changed the title
—exclude-checks support--exclude-checks support
|
@adamsilverstein Just as an FYI, I'll update the GitHub Action right after merging this one. |
mukeshpanchal27
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #308
Successfully tested using something like this: