Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update severity of certain checks in Plugin_Readme_Check #279

Merged
merged 2 commits into from
Sep 25, 2023
Merged

Update severity of certain checks in Plugin_Readme_Check #279

merged 2 commits into from
Sep 25, 2023

Conversation

mukeshpanchal27
Copy link
Member

This PR address first bullet point in #253 issue.

Checklist:

@mukeshpanchal27 mukeshpanchal27 marked this pull request as ready for review September 25, 2023 09:19
felixarntz
felixarntz approved these changes Sep 25, 2023
View reviewed changes
Copy link
Member

@felixarntz felixarntz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @mukeshpanchal27, LGTM!

@felixarntz felixarntz merged commit 29a870c into trunk Sep 25, 2023
13 checks passed
@felixarntz felixarntz deleted the fix/253-update-severity-of-readme-check branch September 25, 2023 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixarntz felixarntz felixarntz approved these changes

@swissspidy swissspidy swissspidy approved these changes

@spacedmonkey spacedmonkey Awaiting requested review from spacedmonkey

@joemcgill joemcgill Awaiting requested review from joemcgill

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mukeshpanchal27 @swissspidy @felixarntz