Skip to content

Commit

Permalink
Merge pull request #796 from WordPress/791-minimum-php-version-bump
Browse files Browse the repository at this point in the history
Bump minimum PHP support to 7.4
  • Loading branch information
ernilambar authored Nov 19, 2024
2 parents 608225a + 805e661 commit e4e75f1
Show file tree
Hide file tree
Showing 10 changed files with 18 additions and 23 deletions.
4 changes: 1 addition & 3 deletions .github/workflows/behat-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -60,8 +60,6 @@ jobs:
fail-fast: true
matrix:
php:
- '7.2'
- '7.3'
- '7.4'
- '8.0'
- '8.1'
Expand All @@ -70,7 +68,7 @@ jobs:
- php: '8.2'
wordpress: 'latest'
coverage: true
- php: '7.2'
- php: '7.4'
wordpress: '6.3'
- php: '8.3'
wordpress: 'trunk'
Expand Down
5 changes: 1 addition & 4 deletions .github/workflows/php-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -48,13 +48,12 @@ jobs:
fail-fast: true
matrix:
php:
- '7.3'
- '7.4'
- '8.0'
- '8.1'
wordpress: [ 'latest' ]
include:
- php: '7.2'
- php: '7.4'
wordpress: '6.3'
- php: '8.2'
wordpress: 'latest'
Expand Down Expand Up @@ -115,8 +114,6 @@ jobs:
fail-fast: true
matrix:
php:
- '7.2'
- '7.3'
- '7.4'
- '8.0'
- '8.1'
Expand Down
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ Thank you for your interest in contributing to the Plugin Check plugin!
In general, all code must follow the [WordPress Coding Standards and best practices](https://developer.wordpress.org/coding-standards/). All code in the Plugin Check plugin must follow these requirements:

- **WordPress**: The plugin's minimum WordPress version requirement is 6.3.
- **PHP**: Always match the latest WordPress version. The minimum required version right now is 7.2.24.
- **PHP**: The minimum required version right now is 7.4.

## Guidelines

Expand Down
4 changes: 2 additions & 2 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"license": "GPL-2.0-or-later",
"type": "wordpress-plugin",
"require": {
"php": ">=7.2.24",
"php": ">=7.4",
"ext-json": "*",
"afragen/wordpress-plugin-readme-parser": "dev-master#67fba498d0b112acf84386b95e4905c539a33f0b",
"automattic/vipwpcs": "^3.0.0",
Expand Down Expand Up @@ -56,7 +56,7 @@
"phpstan/extension-installer": true
},
"platform": {
"php": "7.2.24"
"php": "7.4"
}
},
"scripts": {
Expand Down
6 changes: 3 additions & 3 deletions composer.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions phpcs-sniffs/composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
}
],
"require": {
"php": ">=7.2.24",
"php": ">=7.4",
"ext-libxml": "*",
"ext-tokenizer": "*",
"ext-xmlreader": "*",
Expand All @@ -38,7 +38,7 @@
"dealerdirect/phpcodesniffer-composer-installer": true
},
"platform": {
"php": "7.2.24"
"php": "7.4"
}
},
"scripts": {
Expand Down Expand Up @@ -67,4 +67,4 @@
"lint": "Lint PHP files against parse errors.",
"run-tests": "Run all the unit tests for the Plugin Check Coding Standards sniffs."
}
}
}
6 changes: 3 additions & 3 deletions phpcs-sniffs/composer.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion phpcs-sniffs/phpcs.xml.dist
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
</rule>

<!-- Check code for cross-version PHP compatibility. -->
<config name="testVersion" value="7.2-"/>
<config name="testVersion" value="7.4-"/>

<!-- Enforce PSR1 compatible namespaces. -->
<rule ref="PSR1.Classes.ClassDeclaration"/>
Expand Down
2 changes: 1 addition & 1 deletion phpcs.xml.dist
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<description>Sniffs for WordPress plugins, with minor modifications for Performance</description>

<rule ref="PHPCompatibility"/>
<config name="testVersion" value="7.2-"/>
<config name="testVersion" value="7.4-"/>

<rule ref="WordPress-Core">
<exclude name="WordPress.Files.FileName"/>
Expand Down
4 changes: 2 additions & 2 deletions plugin.php
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
* Plugin URI: https://github.com/WordPress/plugin-check
* Description: Plugin Check is a WordPress.org tool which provides checks to help plugins meet the directory requirements and follow various best practices.
* Requires at least: 6.3
* Requires PHP: 7.2.24
* Requires PHP: 7.4
* Version: 1.2.0
* Author: WordPress Performance Team and Plugin Review Team
* License: GPLv2 or later
Expand All @@ -17,7 +17,7 @@
use WordPress\Plugin_Check\Plugin_Main;

define( 'WP_PLUGIN_CHECK_VERSION', '1.2.0' );
define( 'WP_PLUGIN_CHECK_MINIMUM_PHP', '7.2.24' );
define( 'WP_PLUGIN_CHECK_MINIMUM_PHP', '7.4' );
define( 'WP_PLUGIN_CHECK_MAIN_FILE', __FILE__ );
define( 'WP_PLUGIN_CHECK_PLUGIN_DIR_PATH', plugin_dir_path( WP_PLUGIN_CHECK_MAIN_FILE ) );
define( 'WP_PLUGIN_CHECK_PLUGIN_DIR_URL', plugin_dir_url( WP_PLUGIN_CHECK_MAIN_FILE ) );
Expand Down

0 comments on commit e4e75f1

Please sign in to comment.