Update tests to reflect new changes

WordPress · Dec 26, 2023 · bb56374 · bb56374
1 parent f603ecd
commit bb56374
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 6 deletions.
diff --git a/includes/Admin/Admin_Page.php b/includes/Admin/Admin_Page.php
@@ -220,20 +220,22 @@ public function filter_plugin_action_links( $actions, $plugin_file, $plugin_data
 
 		$plugin_check_base_name = plugin_basename( WP_PLUGIN_CHECK_MAIN_FILE );
 
+		if ( in_array( $context, array( 'mustuse', 'dropins' ), true ) ) {
+			return $actions;
+		}
+
 		if ( $plugin_check_base_name === $plugin_file ) {
 			$actions = array_merge(
 				array(
-					'plugin-check' => sprintf(
+					sprintf(
 						'<a href="%1$s">%2$s</a>',
 						esc_url( admin_url( 'tools.php?page=plugin-check' ) ),
 						esc_html__( 'Plugin Check', 'plugin-check' )
 					),
 				),
 				$actions
 			);
-		}
 
-		if ( in_array( $context, array( 'mustuse', 'dropins' ), true ) || $plugin_check_base_name === $plugin_file ) {
 			return $actions;
 		}
 

diff --git a/tests/phpunit/tests/Admin/Admin_Page_Tests.php b/tests/phpunit/tests/Admin/Admin_Page_Tests.php
@@ -155,12 +155,13 @@ public function test_filter_plugin_action_links() {
 		);
 	}
 
-	public function test_filter_plugin_action_links_should_not_add_check_link_for_plugin_checker() {
+	public function test_filter_plugin_action_links_plugin_should_have_self_admin_page_link_only() {
 
 		$base_file = plugin_basename( WP_PLUGIN_CHECK_MAIN_FILE );
 
 		$action_links = $this->admin_page->filter_plugin_action_links( array(), $base_file, array(), 'all' );
-		$this->assertEmpty( $action_links );
+		$this->assertNotEmpty( $action_links );
+		$this->assertEquals( 1, count( $action_links ) );
 
 		/** Administrator check */
 		$admin_user = self::factory()->user->create( array( 'role' => 'administrator' ) );
@@ -171,7 +172,16 @@ public function test_filter_plugin_action_links_should_not_add_check_link_for_pl
 		wp_set_current_user( $admin_user );
 		$action_links = $this->admin_page->filter_plugin_action_links( array(), $base_file, array(), 'all' );
 
-		$this->assertEmpty( $action_links );
+		$this->assertEquals( 1, count( $action_links ) );
+
+		$this->assertEquals(
+			sprintf(
+				'<a href="%1$s">%2$s</a>',
+				esc_url( admin_url( 'tools.php?page=plugin-check' ) ),
+				esc_html__( 'Plugin Check', 'plugin-check' )
+			),
+			$action_links[0]
+		);
 	}
 
 	/**