Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing additional arg seperator required to run Codecov coverage. #1653

Draft
wants to merge 6 commits into
base: trunk
Choose a base branch
from

Conversation

sarthak-19
Copy link
Contributor

@sarthak-19 sarthak-19 commented Nov 13, 2024

Summary

This PR fixes the currently broken automated codecov coverage in github workflow.

Fixes #

Issue : #1284

Problem Reference - #1652 (comment)

Additional Technical Details Required

As mentioned here - #1586 (comment)

Additionally, the coverage report for each plugin is getting overwritten to the same XML file. There needs to be separate XML files generated for each plugin.
Lovekesh has some additional thoughts.

Currently the xml file name is being generated like coverage-multisite-${{ github.sha }}.xml, so if it's getting overwritten for each plugin, what different identifier can we use here so that it's unique for each plugin ?

cc : @thelovekesh @westonruter

@westonruter westonruter added [Type] Bug An existing feature is broken no milestone PRs that do not have a defined milestone for release Infrastructure Issues for the overall performance plugin infrastructure labels Nov 13, 2024
@sarthak-19
Copy link
Contributor Author

The test is still failing, even after adding an additional arg seperator --, I ran a ls -la command to debug, the coverage file is not getting stored at root of the project.
Is that the cause or any other.

I'm not able to debug and stuck here, any help or insights would be instrumental.

cc : @thelovekesh @westonruter

@westonruter
Copy link
Member

I see this https://github.com/WordPress/performance/actions/runs/11825633049/job/32949852740?pr=1653#step:12:49 which seems to be the problem:

warning - 2024-11-13 20:58:58,206 -- Some files were not found --- {"not_found_files": ["coverage-6c3bb1148143cc38a09cb04f2cf7400b806d21c2.xml"]}

@sarthak-19
Copy link
Contributor Author

I see this https://github.com/WordPress/performance/actions/runs/11825633049/job/32949852740?pr=1653#step:12:49 which seems to be the problem:

warning - 2024-11-13 20:58:58,206 -- Some files were not found --- {"not_found_files": ["coverage-6c3bb1148143cc38a09cb04f2cf7400b806d21c2.xml"]}

Yes, there's no coverage file to upload and hence the test is failing, however the WorkFlow before uploading is running (where xml file is generated ) and the hash is also same I verified.
So is there a way to determine that if the file is properly getting generated or not or is this some directory path issue.
Maybe file is getting stored somewhere else, and I'm trying to upload the file from root of the project.

cc : @westonruter

@westonruter
Copy link
Member

I believe @thelovekesh has in mind what is wrong there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Infrastructure Issues for the overall performance plugin infrastructure no milestone PRs that do not have a defined milestone for release [Type] Bug An existing feature is broken
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants