-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Nuxt and create shared folder #5187
base: main
Are you sure you want to change the base?
Conversation
Latest k6 run output1
Footnotes
|
Full-stack documentation: https://docs.openverse.org/_preview/5187 Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again. You can check the GitHub pages deployment action list to see the current status of the deployments. |
670c55b
to
49ef3fd
Compare
Description
This PR updates Nuxt to the latest version, 3.14.15.
This version introduces the
shared
directory for code that is used both by the server and by the client-side app. This is important because Nuxt does not allow the server code to import from the Nuxt app portions of the app (e.g.,useNuxtApp
).This will be important for adding server-side cache for media provider stats, and for proxying API requests through the Nuxt server, and will be added in a follow-up PR.
Please, don't be intimidated by the number of changed lines: most of them are either in the lock file, or in the imports.
I updated the ESLint rule for ordering the imports to make it more strict, so now we won't have too much variability. You can check the new rules in
packages/js/eslint-plugin/src/configs/import.ts
, and add suggestions on the order.I moved all utils, constants and types that do not import anything from the nuxt app side to
shared
folder. Nuxt does notThat is what the most of the changes in this PR relate to.
Testing Instructions
The app should run as usual without any warnings. The CI should pass.
Checklist
Update index.md
).main
) or a parent feature branch.ov just catalog/generate-docs
for catalogPRs) or the media properties generator (
ov just catalog/generate-docs media-props
for the catalog or
ov just api/generate-docs
for the API) where applicable.Developer Certificate of Origin
Developer Certificate of Origin