-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce threshold for color matching in VRT #5182
Conversation
9449cb0
to
8976d0d
Compare
8976d0d
to
84eec43
Compare
Latest k6 run output1
Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for extracting the changes! The color changes are clearly visible in the snapshots.
I hope 0.1 is not too low and won't make the tests flaky. We can update it to a slightly higher value if we notice flakiness.
Description
This PR reduces the threshold for color matching in Playwright tests. This causes a number of snapshots to be updated that were previously not updated even when the code was changed and their visual appearance also changed.
Checklist
Update index.md
).main
) or a parent feature branch.ov just catalog/generate-docs
for catalogPRs) or the media properties generator (
ov just catalog/generate-docs media-props
for the catalog or
ov just api/generate-docs
for the API) where applicable.Developer Certificate of Origin
Developer Certificate of Origin