Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce threshold for color matching in VRT #5182

Merged
merged 2 commits into from
Nov 25, 2024
Merged

Reduce threshold for color matching in VRT #5182

merged 2 commits into from
Nov 25, 2024

Conversation

dhruvkb
Copy link
Member

@dhruvkb dhruvkb commented Nov 25, 2024

Description

This PR reduces the threshold for color matching in Playwright tests. This causes a number of snapshots to be updated that were previously not updated even when the code was changed and their visual appearance also changed.

Checklist

  • My pull request has a descriptive title (not a vague title likeUpdate index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.
  • I ran the DAG documentation generator (ov just catalog/generate-docs for catalog
    PRs) or the media properties generator (ov just catalog/generate-docs media-props
    for the catalog or ov just api/generate-docs for the API) where applicable.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@openverse-bot openverse-bot added 🧱 stack: frontend Related to the Nuxt frontend 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work labels Nov 25, 2024
@dhruvkb dhruvkb added 🟧 priority: high Stalls work on the project or its dependents 🛠 goal: fix Bug fix 💻 aspect: code Concerns the software code in the repository and removed 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work labels Nov 25, 2024
Copy link

github-actions bot commented Nov 25, 2024

Latest k6 run output1

     ✓ status was 200

     checks.........................: 100.00% ✓ 6400      ✗ 0   
     data_received..................: 1.5 GB  7.4 MB/s
     data_sent......................: 837 kB  4.1 kB/s
     http_req_blocked...............: avg=12.66µs  min=1.91µs  med=4.43µs   max=6.54ms  p(90)=5.97µs   p(95)=6.6µs   
     http_req_connecting............: avg=7.91µs   min=0s      med=0s       max=6.5ms   p(90)=0s       p(95)=0s      
     http_req_duration..............: avg=701.99ms min=46.51ms med=609.46ms max=2.7s    p(90)=1.27s    p(95)=1.38s   
       { expected_response:true }...: avg=701.99ms min=46.51ms med=609.46ms max=2.7s    p(90)=1.27s    p(95)=1.38s   
   ✓ http_req_failed................: 0.00%   ✓ 0         ✗ 6400
     http_req_receiving.............: avg=159.78µs min=43.61µs med=129.2µs  max=22.6ms  p(90)=203.29µs p(95)=248.43µs
     http_req_sending...............: avg=26.19µs  min=5.93µs  med=20.46µs  max=13.35ms p(90)=27.38µs  p(95)=30.03µs 
     http_req_tls_handshaking.......: avg=0s       min=0s      med=0s       max=0s      p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=701.8ms  min=46.29ms med=609.31ms max=2.7s    p(90)=1.27s    p(95)=1.38s   
     http_reqs......................: 6400    31.653212/s
     iteration_duration.............: avg=3.75s    min=1.02s   med=3.15s    max=9.59s   p(90)=7.34s    p(95)=7.67s   
     iterations.....................: 1200    5.934977/s
     vus............................: 5       min=5       max=30
     vus_max........................: 30      min=30      max=30

Footnotes

  1. This comment will automatically update with new output each time k6 runs for this PR

@dhruvkb dhruvkb marked this pull request as ready for review November 25, 2024 10:14
@dhruvkb dhruvkb requested a review from a team as a code owner November 25, 2024 10:14
Copy link
Contributor

@obulat obulat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for extracting the changes! The color changes are clearly visible in the snapshots.
I hope 0.1 is not too low and won't make the tests flaky. We can update it to a slightly higher value if we notice flakiness.

@dhruvkb dhruvkb merged commit 8c1c3b1 into main Nov 25, 2024
53 checks passed
@dhruvkb dhruvkb deleted the update_color_snaps branch November 25, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟧 priority: high Stalls work on the project or its dependents 🧱 stack: frontend Related to the Nuxt frontend
Projects
Status: 🤝 Merged
Development

Successfully merging this pull request may close these issues.

3 participants