Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily disable saving clean tags to disk #2557

Merged
merged 1 commit into from
Jul 5, 2023

Conversation

obulat
Copy link
Contributor

@obulat obulat commented Jul 5, 2023

Fixes

Fixes #2556 by @obulat

Description

This PR adds a check for the field when saving the cleaned up data. We skip tags so that the disk space is not filled up during the data refresh. The tags are still cleaned before saving them to the database.

Testing Instructions

I used the csv data from the gist in this PR description: from #904 . The sample data loading has been updated to check for document count in the index, and to test locally I disabled those checks (because there are only 1900 images in that gist).
When I ran just init, I saw the files in the /ingestion_server folder, without tags.csv.

Checklist

  • My pull request has a descriptive title (not a vague title likeUpdate index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.
  • I ran the DAG documentation generator (if applicable).

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@obulat obulat requested a review from a team as a code owner July 5, 2023 16:19
@obulat obulat requested review from krysal and dhruvkb July 5, 2023 16:19
@obulat obulat self-assigned this Jul 5, 2023
@github-actions github-actions bot added the 🧱 stack: ingestion server Related to the ingestion/data refresh server label Jul 5, 2023
@openverse-bot openverse-bot added 🟥 priority: critical Must be addressed ASAP ✨ goal: improvement Improvement to an existing user-facing feature 💻 aspect: code Concerns the software code in the repository labels Jul 5, 2023
@zackkrida zackkrida merged commit 680122f into main Jul 5, 2023
@zackkrida zackkrida deleted the fix/not_save_cleaned_tags branch July 5, 2023 17:31
@krysal krysal mentioned this pull request Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository ✨ goal: improvement Improvement to an existing user-facing feature 🟥 priority: critical Must be addressed ASAP 🧱 stack: ingestion server Related to the ingestion/data refresh server
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Saving clean tags during data refresh fills up the disk
5 participants