Block Editor: Correctly mark Block Comment SlotFills private #67271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -29 B (0%) Total Size: 1.82 MB
ℹ️ View Unchanged
|
jsnajdr
reviewed
Nov 25, 2024
| ); | ||
|
|
||
| __unstableCommentIconFill.Slot = Slot; | ||
| CommentIconFill.Slot = Slot; |
There was a problem hiding this comment.
If this is a private API, let's fix it by exporting the return value of createSlotFill without any further modifications. We can call it CommentIconSlotFill and use its .Slot and .Fill fields. No needs to have a Fill compoennt with a Fill.Slot field.
Same thing can be done for CommentIconToolbarSlotFill.
There was a problem hiding this comment.
Updated. I'm sure the names will change again before the feature is stabilized, but it should be good for now.
jsnajdr
approved these changes
Nov 26, 2024
|
Thanks, @jsnajdr! |
valerogarte
pushed a commit
to valerogarte/gutenberg
that referenced
this pull request
Nov 27, 2024
…ss#67271) * Block Editor: Correctly mark Block Comment SlotFills private * Drop '__unstable' prefix * Simplify private API exports Co-authored-by: Mamaduka <[email protected]> Co-authored-by: jsnajdr <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
PR updates block comment SlotFills and correctly mark them as private, preventing "leaking" them to consumers using string names.
I've also removed the
__unstableprefix; it's not needed for private APIs.Remembered this case while reviewing #67238.
Testing Instructions
Test the "leak"
Testing Instructions for Keyboard
Same.
Screenshots or screencast