Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project Bundle Visualizer #52

Merged
merged 1 commit into from
Jul 6, 2024
Merged

Project Bundle Visualizer #52

merged 1 commit into from
Jul 6, 2024

Conversation

sirbully
Copy link
Contributor

@sirbully sirbully commented Jul 6, 2024

Resolves #50

What changed 🧐

Please list the changes that are in this PR

  • Added vite-bundle-visualizer and visualize script

⚠️ Upon checking, @mui is affecting our project's bundle size a lot.

Our project gzipped is 251.15KB. @mui by itself is 100.4KB (39.98%). It is important to note that@mui depends on:

  • @emotion: 12.68KB -> which depends on stylis (4.05KB)
  • react-transition-group: 4.49KB

In total, MUI is taking up 121.62KB to work properly which is 48.43% of our project bundle size. Hopefully we can address this in the future 🙏

Screenshot 2024-07-06 at 21 39 07

How did you test it? 🧪

Please describe new unit tests, E2E tests, or manual testing steps.

@sirbully sirbully requested a review from ann-kilzer July 6, 2024 13:12
@sirbully sirbully self-assigned this Jul 6, 2024
package.json Outdated Show resolved Hide resolved
Copy link
Collaborator

@ann-kilzer ann-kilzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a great tool.

I'm not surprised that MUI takes up a significant portion of the dependencies, as the site is only two pages. User-facing metrics like load times matter more.

Another important thing to manage in open-source side projects is developer energy. This is a part time commitment for people, and that's okay. Keeping our workload simple and leveraging existing tools will give us more time to focus on community building.

@sirbully sirbully changed the base branch from 6-coverage to main July 6, 2024 13:44
@sirbully sirbully force-pushed the 50-project-bundle-visualizer branch from 200271d to 27c03b4 Compare July 6, 2024 13:48
@sirbully sirbully merged commit 3ded3fe into main Jul 6, 2024
6 checks passed
@sirbully sirbully deleted the 50-project-bundle-visualizer branch July 6, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Project Bundle Visualizer
2 participants