Contributor edit endpoint #11
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicozar95
suggested changes
Apr 20, 2020
Comment on lines
11
to
13
| def render_error(status, message) | ||
| render json: message, status: status | ||
| end |
There was a problem hiding this comment.
You are not using this method, we could delete it
marcegl91
reviewed
Apr 21, 2020
|
|
||
| def update | ||
| contributor = Contributor.find(params[:id]) | ||
| return render json: contributor, status: :ok if contributor.update(update_params) |
There was a problem hiding this comment.
I think that the status: :ok bit is not needed, maybe you can check which response code gives if you delete that?
app/policies/contributor_policy.rb
Outdated
| class ContributorPolicy < ApplicationPolicy | ||
| attr_reader :user, :contributor | ||
|
|
||
| def initialize(user, post) |
There was a problem hiding this comment.
It seems that this class is not needed, provided that we don't have a Post model in this project.
nicozar95
approved these changes
Apr 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Contributor update endpoint
with tests
login will be done after along with pundiit
Screenshots
[Change!] Show the screenshots of the views you modified.
Trello Card