Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kube-prometheus-stack] add recording rule pod_start_time:kube_node_info #69

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

frezes
Copy link
Collaborator

@frezes frezes commented Jul 9, 2024

What this PR does / why we need it

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

  • fixes #

Special notes for your reviewer

Checklist

  • DCO signed
  • Chart Version bumped
  • Title of the PR starts with chart name (e.g. [prometheus-couchdb-exporter])

@frezes
Copy link
Collaborator Author

frezes commented Jul 9, 2024

https://github.com/kubesphere/project/issues/3983#issuecomment-2217139418

这个的 name 是 recording rules 的名字,由于需要按照创建时间排序,将 kube_pod_create_time 进行级联作为 values

@frezes frezes requested a review from junotx July 9, 2024 09:44
)
* on (cluster, namespace, pod) group_left (workspace, qos_class, phase)
workspace_workload_node:kube_pod_info:
record: 'pod_start_time:kube_node_info:'
Copy link
Member

@benjaminhuo benjaminhuo Jul 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kube_pod_start_time 和 kube_pod_info 结合应该是 pod_start_time:kube_pod_info: ,而不是 pod_start_time:kube_node_info: 吧?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

拼写错误,我修改下

@frezes frezes force-pushed the feat/updateMetricDenyList branch from f3f0f0d to 8a685c7 Compare July 9, 2024 10:06
@benjaminhuo
Copy link
Member

先 merge 了,@junotx 看下有什么问题可以 comments

@benjaminhuo benjaminhuo merged commit 06d2cd3 into WizTelemetry:main Jul 9, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants