[kube-prometheus-stack] update recording rules #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: frezes <[email protected]>
frezes
force-pushed
the
feat/kube-prometheus-stack
branch
from
e3e9c6b to
f227a2f
Compare
benjaminhuo
reviewed
Jan 31, 2024
| @@ -46,7 +46,26 @@ spec: | |||
| {{- toYaml . | nindent 8 }} | |||
| {{- end }} | |||
| {{- end }} | |||
| - expr: sum by (cluster, node, instance, host_ip)(node_memory_MemTotal_bytes{job="node-exporter"} -(node_memory_MemAvailable_bytes{job="node-exporter"} or (node_memory_Buffers_bytes{job="node-exporter"} + node_memory_Cached_bytes{job="node-exporter"} + node_memory_MemFree_bytes{job="node-exporter"} + node_memory_Slab_bytes{job="node-exporter"}))) * on (cluster,node) group_left(role) ((kube_node_role{job="kube-state-metrics", role="worker"} unless ignoring (role) kube_node_role{job="kube-state-metrics", role="control-plane"}) or kube_node_role{job="kube-state-metrics", role="control-plane"}) | |||
| - expr: |- | |||
| sum by (cluster, node) ( | |||
There was a problem hiding this comment.
It's safe to remove instance, host_ip?
benjaminhuo
reviewed
Jan 31, 2024
| @@ -57,7 +76,12 @@ spec: | |||
| {{- toYaml . | nindent 8 }} | |||
| {{- end }} | |||
| {{- end }} | |||
| - expr: sum by (cluster, node, instance, host_ip, role)(node_memory_MemTotal_bytes{job="node-exporter"} * on (cluster,node) group_left(role) ((kube_node_role{job="kube-state-metrics", role="worker"} unless ignoring (role) kube_node_role{job="kube-state-metrics", role="control-plane"}) or kube_node_role{job="kube-state-metrics", role="control-plane"})) | |||
| - expr: |- | |||
| sum by (cluster, node) ( | |||
There was a problem hiding this comment.
safe to remove instance, host_ip, role?
benjaminhuo
reviewed
Jan 31, 2024
| @@ -68,8 +92,8 @@ spec: | |||
| {{- toYaml . | nindent 8 }} | |||
| {{- end }} | |||
| {{- end }} | |||
| - expr: node:node_filesystem_bytes_used_total:sum / node:node_filesystem_bytes_total:sum | |||
| record: node:node_filesystem_utilisation:ratio | |||
| - expr: node:node_device_filesystem_bytes_used_total:sum / node:node_device_filesystem_bytes_total:sum | |||
There was a problem hiding this comment.
what's the reason of changing node:node_filesystem_bytes_ to node:node_device_filesystem_bytes_ ?
benjaminhuo
reviewed
Jan 31, 2024
| max by (cluster, node, instance, host_ip, device) ( | ||
| node_filesystem_size_bytes{device=~"/dev/.*",device!~"/dev/loop\\d+", job="node-exporter"} | ||
| ) * on (cluster,node) group_left(role) ((kube_node_role{job="kube-state-metrics", role="worker"} unless ignoring (role) kube_node_role{job="kube-state-metrics", role="control-plane"}) or kube_node_role{job="kube-state-metrics", role="control-plane"}) | ||
| sum by (cluster, node, device) ( |
There was a problem hiding this comment.
again instance, host_ip are not necessary?
benjaminhuo
reviewed
Jan 31, 2024
| @@ -134,7 +214,12 @@ spec: | |||
| {{- toYaml . | nindent 8 }} | |||
| {{- end }} | |||
| {{- end }} | |||
| - expr: sum by(cluster,node,host_ip,role)(kube_pod_status_scheduled{job="kube-state-metrics", condition="true"} * on(cluster,namespace,pod) group_left(node,host_ip,role) workspace_workload_node:kube_pod_info:) | |||
| - expr: |- | |||
There was a problem hiding this comment.
host_ip,role also removed here
benjaminhuo
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)Special notes for your reviewer
Checklist
[prometheus-couchdb-exporter])