Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kube-prometheus-stack] fix recording rules #36

Merged
merged 1 commit into from
Dec 26, 2023

Conversation

frezes
Copy link
Collaborator

@frezes frezes commented Dec 26, 2023

What this PR does / why we need it

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

  • fixes #

Special notes for your reviewer

Checklist

  • DCO signed
  • Chart Version bumped
  • Title of the PR starts with chart name (e.g. [prometheus-couchdb-exporter])

@frezes frezes force-pushed the feat/customizingRules branch from 7c9cc1f to 90c4fd6 Compare December 26, 2023 08:39
@benjaminhuo
Copy link
Member

@junotx

Copy link
Collaborator

@junotx junotx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/assign @benjaminhuo

@benjaminhuo benjaminhuo merged commit 472d40f into WizTelemetry:main Dec 26, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants