Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[prometheus-node-exporter] update process-exporter-rules as globalrulegroups #32

Merged
merged 1 commit into from
Dec 21, 2023

Conversation

junotx
Copy link
Collaborator

@junotx junotx commented Dec 21, 2023

What this PR does / why we need it

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

  • fixes #

Special notes for your reviewer

Checklist

  • DCO signed
  • Chart Version bumped
  • Title of the PR starts with chart name (e.g. [prometheus-couchdb-exporter])

@benjaminhuo
Copy link
Member

benjaminhuo commented Dec 21, 2023

Don't forget to remove the previous ClusterRuleGroup when upgrading from 3.5 to 4.1 @junotx

@benjaminhuo
Copy link
Member

cc @wrongerror

@benjaminhuo benjaminhuo merged commit 5e60eb5 into WizTelemetry:main Dec 21, 2023
2 checks passed
@junotx junotx deleted the processrules branch December 22, 2023 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants