Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated load_7zip to Install the Latest Version (24.08) and Added load_7zip64 #2302

Closed
wants to merge 1 commit into from

Conversation

ThisNekoGuy
Copy link
Contributor

@ThisNekoGuy ThisNekoGuy commented Nov 20, 2024

Updated load_7zip to install latest version and added load_7zip64

  • Brings the 32-bit version up to date
  • Adds the 64-bit version as an installation option

@austin987
Copy link
Contributor

A) Please rebase to latest (7-zip was recently updated to 24.09)
B) I don't think a separate verb here makes sense. Instead, it should detect if the WINEPREFIX is 64-bit, and install the 64-bit version instead of the 32-bit one.

Updated 7zip to 24.09; removed 7zip64 verb in favor for arch bits conditional installation
@ThisNekoGuy
Copy link
Contributor Author

Accidentally closed this, but I'm trying to address the issues you mentioned @austin987

@austin987 austin987 reopened this Dec 17, 2024
@austin987
Copy link
Contributor

austin987 commented Dec 17, 2024

BTW, you can use if [ "${W_ARCH}" = "win64" ]; then ... to check for a 64-bit prefix.

@ThisNekoGuy ThisNekoGuy closed this by deleting the head repository Dec 17, 2024
@ThisNekoGuy
Copy link
Contributor Author

I actually came across this a few moments ago 😅
Originally thought there wasn't a variable for it and thought of using grep, then did some thinking afterwards and found it did actually exist after some searching

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants