Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor update to win64 warning messages to support toggling via env var #2184

Merged

Conversation

zpangwin
Copy link
Contributor

@zpangwin zpangwin commented Feb 5, 2024

This adds support to allow users to export W_NO_WIN64_WARNINGS=1 for toggling off win64 warning messages (this new way is in addition to the file-based logic from an earlier commit and so should not break any existing setups).

This proposal and the advantages were previously discussed in the comments of issue #1730 but for convenience, those were:

  1. Allows users to completely suppress the message (including echo statement from touched file) if they really want to

  2. Allows to set an environment variable for a terminal session but not forever (or alternately could use .bashrc or equivalent for all terminal sessions)

  3. Reduced number of I/O hits checking for a file (I know it is an extremely minor I/O hit but it's still technically a plus)

  4. This also allows a user to temporarily turn the warning back on if they have created the file but wish to restore the warning temporarily such as for a single debugging session.

I think the actual changes should be pretty straight forward and keeping with the same coding style. But if there are any issues / questions / comments / etc, please let me know.

…ed env var in addition to current approach (per proposal in issue Winetricks#1730 comments)
@zpangwin zpangwin changed the title minor update to win64 warning messages to support toggling via exporting env var minor update to win64 warning messages to support toggling via env var Feb 5, 2024
@austin987 austin987 merged commit 16ab1ea into Winetricks:master Apr 27, 2024
5 checks passed
@austin987
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants