minor update to win64 warning messages to support toggling via env var #2184
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support to allow users to
export W_NO_WIN64_WARNINGS=1
for toggling off win64 warning messages (this new way is in addition to the file-based logic from an earlier commit and so should not break any existing setups).This proposal and the advantages were previously discussed in the comments of issue #1730 but for convenience, those were:
I think the actual changes should be pretty straight forward and keeping with the same coding style. But if there are any issues / questions / comments / etc, please let me know.