Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

winetricks dotnetdesktop8 not work please solve #2179

Closed
wants to merge 5 commits into from

Conversation

amidevous
Copy link

winetricks dotnetdesktop8 not work please solve

solve issues

#2178

require emergengie update for all linux distribution

for add support netframework 8.0 support

@amidevous
Copy link
Author

update include all version of net 7 and net 8

it is necessary for net framework 7 and 8

to make available all versions

because when a program requests version 7.0.10

7.0.0 or 7.0.15 does not work

please rapid update on this git for add update work for all with

sudo winetricks --self-update

@austin987
Copy link
Contributor

This PR needs work:

  • You have 5 commits just called 'Update winetricks', commits should specify exactly what they do, e.g., dotnet715: new verb
  • I don't love having to add several .net versions, but having dealt with this recently at my day job, I'm aware that it's not as backwards compatible as expected. That said, the generic dotnet7 shouldn't hardcode a version, but instead call the latest version (i.e., add dotnet715, then have dotnet7 call dotnet715).
  • Please break the commits into smaller changes, following the above guidelines.

@austin987 austin987 closed this Apr 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants