Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

my_package oci #75

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

mkrunic-windriver
Copy link
Contributor

Added all necessary files and explanation how to create a my_package.oci VxWorks container image.

@razr
Copy link
Collaborator

razr commented Jul 25, 2023

Thanks for the PR! Could you please move it under examples/vxc instead of Docker, and create_my_package_container.sh under scripts while renaming it to create_vxc_container.sh. I don't think this script is my_package specific. Does this script really create a container as it is stated in its name?

├── examples
│   └── vxc
│      ├── my_package - VxWorks ROS2 container examples
│         ├── Dockerfile
│         └── README.md
├── scripts
│   └── create_vxc_container.sh

@mkrunic-windriver
Copy link
Contributor Author

I have refactored folder structure according to the review comment. Regards "Does this script really create a container as it is stated in its name", the answer is it creates container payload, so I have renamed it to be more precise.

scripts/create_vxc_container_payload.sh Outdated Show resolved Hide resolved
scripts/create_vxc_container_payload.sh Outdated Show resolved Hide resolved
scripts/create_vxc_container_payload.sh Outdated Show resolved Hide resolved
scripts/create_vxc_container_payload.sh Outdated Show resolved Hide resolved
scripts/create_vxc_container_payload.sh Show resolved Hide resolved
scripts/create_vxc_container_payload.sh Outdated Show resolved Hide resolved
examples/vxc/my_package/README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
scripts/create_vxc_container_payload.sh Show resolved Hide resolved
scripts/create_vxc_container_payload.sh Outdated Show resolved Hide resolved
@mkrunic-windriver
Copy link
Contributor Author

I have addressed all points. Please take a look. Thanks for findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants