-
Notifications
You must be signed in to change notification settings - Fork 2
Miscellaneous Notes
This file appears to contain the same methods that reside in the MatchService class implementing the IMatchService interface. It can be found in the Controllers folder. Commenting out the entire controller appears to have no effect on the web application. Consider possibly deleting this file.
This file appears to contain the same methods that reside in the LawyerService class implementing the ILawyerService interface. It can also be found in the Controllers folder. Commenting out the entire controller appears to have no effect on the web application. Consider possibly deleting this file.
This controllers appear to have been made obsolete by their respective Razor Pages (Lawyer and Veteran). Multiple interfaces have been also used with these Razor Pages to perform CRUD operations in a more secure fashion. Consider possibly deleting these files.
Previous iterations have noted that this class is obsolete and that a lawyer's availability should be established through LawyerLibraryJunction and LawyerSchedule. Iteration 3 has tried commenting out any references to LawyerAvailability and running the application, but appears to still be necessary. Refactor before removing.
Previous iterations have noted that this class is obsolete and that veteran queueing should be handled through timestamps found in the VeteranLibraryJunction table. It appears that this application is still relying on this class in the RequestLawyerViewComponent.cs file. IMatchService also uses this class. Refactor before removing.
There appear to be many test files that are either empty or do not actually have asserts in the test methods. Consider heavily investing into testing during future iterations.
Consider reorganization of files. Currently all services are located in the Service file. All of these are Dependency Injection and could be moved to the Models folder and Interface Folders.