Fix: multiwiki_assignment_spec failure #6088
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t interacts with it
|
This failure is due to the issue in the student_role_spec which i have fixed here, after merging that i will rebuild this and it should work |
ragesoss
reviewed
Jan 4, 2025
| @@ -60,8 +60,9 @@ | |||
| first('textarea').set( | |||
| "Terre\nhttps://fr.wikipedia.org/wiki/Anglais" | |||
| ) | |||
| expect(page).to have_button('Assign all') | |||
| click_button 'Assign all' | |||
There was a problem hiding this comment.
I don't think this will make a difference, as click_button already incorporates Capybara 'wait' behavior. If the button renders in time, it will work either way, and if it takes more than the wait time to render, it will fail at the expect(page)...
There was a problem hiding this comment.
Your right, I thought ensuring the button is found within the #user element, before it is interacted with
when i tested locally running Capybara in headless mode i realized the Assign all button appeared and close very fast
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR addresses the recent failure in the multiwiki_assignment_spec where Capybara was unable to find the button "Assign all" because it possible was not available. The issue is resolved by utilizing Capybara's default wait mechanism, ensuring that the button is present and enabled before interacting with it.
Notes:
The other errors that occurred along with this issue, such as the missing content ("Heyder Cansa" and "Wp/kiu/Hey"), have not occurred recently.
This improvement is due to the increased Capybara wait time, which accounted for the longer period required for the element to become available, thus preventing interaction failures.