Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve Style/StringConcatenation rubocop violations and enable the check for it #6085

Merged
merged 5 commits into from
Jan 3, 2025

Conversation

bhushan354
Copy link
Contributor

NOTE: Please review the pull request process before opening your first PR: https://github.com/WikiEducationFoundation/WikiEduDashboard/blob/master/CONTRIBUTING.md#pull-request-process

What this PR does

Screenshots

Before:
< add a screenshot of the UI before your change >

After:
< add a screenshot of the UI after your change >

Open questions and concerns

< anything you learned that you want to share, or questions you're wondering about related to this PR >

@bhushan354
Copy link
Contributor Author

Hi @ragesoss ,

I’ve been trying to resolve this issue and noticed that all recently opened PRs are failing this specific test. Here’s a screenshot for reference:
Screenshot from 2025-01-03 22-19-40

Do you have any leads on what might be causing this?

@ragesoss
Copy link
Member

ragesoss commented Jan 3, 2025

Thanks for opening this PR!

I think I prefer to keep these string concatenations as they are, rather than change any of the files, I will accept a PR that moves this rule to the 'permanent exceptions' section.

That failing test is one that sometimes fails for unknown reasons. @Formasitchijoh is currently working on a project to improve the test suite's reliability, and I think this test is on the list for investigation.

@ragesoss
Copy link
Member

ragesoss commented Jan 3, 2025

The PR should only include changes to the one file, and should only include a single commit.

@bhushan354
Copy link
Contributor Author

bhushan354 commented Jan 3, 2025

@ragesoss i have reverted the changes in this PR itself , do you want me to create another PR or this one is fine?

@ragesoss
Copy link
Member

ragesoss commented Jan 3, 2025

This is okay, I will squash it. However, I generally prefer PRs that have a well-curated commit history, where only necessary commits are part of it.

@ragesoss ragesoss merged commit 14a906b into WikiEducationFoundation:master Jan 3, 2025
1 check failed
@bhushan354
Copy link
Contributor Author

Thanks for the help! I'll keep that in mind for next time.

Formasitchijoh pushed a commit to Formasitchijoh/WikiEduDashboard that referenced this pull request Jan 6, 2025
…check for it (WikiEducationFoundation#6085)

* move StringConcatenation rule to 'permanent exceptions' section
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants