ArticlefinderRow refactor #5497
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justiceotuya
changed the title
justiceotuya
changed the title
|
@ragesoss here. this is part of my contribution as an outreach intern, please add me to the slack group so I can ask questions |
Sure, please send me an email (sage at wikiedu.org) so I know where to send the invite. |
|
@justiceotuya are you still working on this? (it looks like there are some article finder specs failing; if you're still interested in getting this merged but you are stuck with something, let us know!) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: Please review the pull request process before opening your first PR: https://github.com/WikiEducationFoundation/WikiEduDashboard/blob/master/CONTRIBUTING.md#pull-request-process
What this PR does
refactors article finder to use functional component from this Issue #5393
Screenshots
Before:
After:
Open questions and concerns
< anything you learned that you want to share, or questions you're wondering about related to this PR >