Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor articleFinder to functional component #5493

Conversation

justiceotuya
Copy link
Contributor

@justiceotuya justiceotuya commented Oct 3, 2023

NOTE: Please review the pull request process before opening your first PR: https://github.com/WikiEducationFoundation/WikiEduDashboard/blob/master/CONTRIBUTING.md#pull-request-process

What this PR does

This PR refactors articleFinder from using class component to using functional components from this Issue #5393

Screenshots

Before:
image

After:
image

Open questions and concerns

  • I created a constants file to move away constants
  • I created a hooks folder/file to abstract redux boilerplate selector logic

@justiceotuya
Copy link
Contributor Author

@ragesoss please can i be added to the slack group [email protected] also can you approve the workflow as the test is failing on the ruby end even though I did not work on that end

@justiceotuya
Copy link
Contributor Author

@Aminehassou

@ragesoss ragesoss marked this pull request as draft December 4, 2023 20:25
@ragesoss ragesoss closed this Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants