Clean up empty training table markup

WikiEducationFoundation · Nov 9, 2023 · 81c3516 · 81c3516
1 parent 6c6a878
commit 81c3516
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 0 deletions.
diff --git a/app/assets/javascripts/components/timeline/TrainingModules/TrainingModules.jsx b/app/assets/javascripts/components/timeline/TrainingModules/TrainingModules.jsx
@@ -92,6 +92,8 @@ const TrainingModules = createReactClass({
       />
     ));
 
+    if (!modules.length) { return null; }
+
     const header = this.props.header || 'Training';
     const headerId = header.toLowerCase().split(/[^a-z]/).join('-');
     return (

diff --git a/app/assets/javascripts/components/timeline/TrainingModules/TrainingModulesViewMode.jsx b/app/assets/javascripts/components/timeline/TrainingModules/TrainingModulesViewMode.jsx
@@ -21,6 +21,9 @@ const TrainingModulesViewMode = createReactClass({
     const block = this.props.block;
     const modules = [];
     const length = block.training_modules.length;
+
+    if (!length) { return null; }
+
     const partitioned = block.training_modules.reduce((acc, mod) => {
       let key = 'modules';
         if (mod.kind === EXERCISE_KIND) key = 'exercises';