Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AMD Hardware (H.264, H.265, AV1) + Software AV1 Encoding Support #386

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

waylaa
Copy link

@waylaa waylaa commented Nov 20, 2024

Added support for AMD's hardware H.264, H.265, AV1 encoders and a software AV1 encoder.

@waylaa waylaa mentioned this pull request Dec 2, 2024
@xDololow
Copy link

xDololow commented Dec 5, 2024

Tried running it, works fine with av1_amf, but fails with h264 and hevc returning: panic: encoder "h264_amf": invalid profile: (same invalid profile error for hevc)

@waylaa
Copy link
Author

waylaa commented Dec 5, 2024

Tried running it, works fine with av1_amf, but fails with h264 and hevc returning: panic: encoder "h264_amf": invalid profile: (same invalid profile error for hevc)

Can you try encoding with H.264 and HEVC again? I believe I fixed the issue you were having.

@xDololow
Copy link

xDololow commented Dec 6, 2024

Can you try encoding with H.264 and HEVC again? I believe I fixed the issue you were having.

Yep, now it works.

@xDololow
Copy link

xDololow commented Dec 6, 2024

Experimented more on Windows, if i try to render with these settings:
image
I get this error:
image
It goes for AV1 and H264

logs:
CProgramsdanser-godanser-go.exe.txt

@waylaa
Copy link
Author

waylaa commented Dec 6, 2024

Experimented more on Windows, if i try to render with these settings: image I get this error: image It goes for AV1 and H264

logs: CProgramsdanser-godanser-go.exe.txt

Does this error happen with only this specific rate control and preset? Can you test multiple combinations of rate control and preset settings if possible?

@xDololow
Copy link

xDololow commented Dec 6, 2024

Does this error happen with only this specific rate control and preset? Can you test multiple combinations of rate control and preset settings if possible?

It seems "High Quality Constant Bitrate", "Quality Variable Bitrate" and "High Quality Variable Bitrate" just doesn't work with any preset with all encoders. Same error every time.

@waylaa
Copy link
Author

waylaa commented Dec 6, 2024

Does this error happen with only this specific rate control and preset? Can you test multiple combinations of rate control and preset settings if possible?

It seems "High Quality Constant Bitrate", "Quality Variable Bitrate" and "High Quality Variable Bitrate" just doesn't work with any preset with all encoders. Same error every time.

These rate control methods work just fine on my 6700XT. I guess this can either be an issue with an old version of ffmpeg which I highly doubt since you use 7.0 and I use 7.1 or HQ-CBR, HQ-VBR and QVBR is only supported on dgpus. Might also be a vram issue since these rate control methods take around 2-4gb.

@xDololow
Copy link

xDololow commented Dec 6, 2024

Tried just encoding video with HQ-CBR (-rc 6) and it works no problem. Maybe it's too much for 780m to encode from raw video.

@waylaa
Copy link
Author

waylaa commented Dec 6, 2024

Tried just encoding video with HQ-CBR (-rc 6) and it works no problem. Maybe it's too much for 780m to encode from raw video.

I believe so too. You tried encoding with a dgpu?

@xDololow
Copy link

xDololow commented Dec 6, 2024

I believe so too. You tried encoding with a dgpu?

I don't have amd dgpu, only laptop with 7840hs and mini-pc with 8840hs.

…ixel format requirements + enabled overlays VBR/CRF for increased quality
@waylaa waylaa changed the title AMD Encoding Support (H.264, H.265, AV1) AMD Encoding Support (H.264, H.265, AV1) + Software AV1 Encoder Support Dec 6, 2024
@waylaa waylaa changed the title AMD Encoding Support (H.264, H.265, AV1) + Software AV1 Encoder Support AMD Hardware (H.264, H.265, AV1) + Software AV1 Encoding Support Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants