Fix missing kick sliders not resetting combo

Wieku · Aug 29, 2023 · 42cd0d1 · 42cd0d1
1 parent a807896
commit 42cd0d1
Showing 1 changed file with 3 additions and 7 deletions.
diff --git a/app/rulesets/osu/slider.go b/app/rulesets/osu/slider.go
@@ -292,7 +292,7 @@ func (slider *Slider) UpdatePostFor(player *difficultyPlayer, time int64, proces
 	state := slider.state[player]
 
 	if time > int64(slider.hitSlider.GetStartTime())+player.diff.Hit50 && !state.isStartHit {
-		if len(slider.players) == 1 {
+		if len(slider.players) == 1 && !state.isHit { //don't fade if slider already ended (and armed the start)
 			slider.hitSlider.ArmStart(false, float64(time))
 		}
 
@@ -313,12 +313,8 @@ func (slider *Slider) UpdatePostFor(player *difficultyPlayer, time int64, proces
 	}
 
 	if (time >= int64(slider.hitSlider.GetEndTime()) || (processSliderEndsAhead && int64(slider.hitSlider.GetEndTime())-time == 1)) && !state.isHit {
-		if !state.isStartHit {
-			if len(slider.players) == 1 {
-				slider.hitSlider.ArmStart(false, float64(time))
-			}
-
-			state.isStartHit = true
+		if len(slider.players) == 1 && !state.isStartHit {
+			slider.hitSlider.ArmStart(false, float64(time))
 		}
 
 		if state.startResult != Miss {