Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Add missing function in AppActivationBridge #1072

Open
wants to merge 5 commits into
base: develop_pwa
Choose a base branch
from

Conversation

AlexanderKanakis
Copy link
Collaborator

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

"version": "git+https://github.com/WideChat/Rocket.Chat.Apps-engine.git#7777d4b7702500a3c2ff28aaae9fa8963dba109f",
"from": "git+https://github.com/WideChat/Rocket.Chat.Apps-engine.git#master",
"version": "git+https://github.com/WideChat/Rocket.Chat.Apps-engine.git#35877292b61dea5345685fe2879906b4f1df2977",
"from": "git+https://github.com/WideChat/Rocket.Chat.Apps-engine.git#dialogflow_branch",
Copy link

@ear-dev ear-dev Feb 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NOTE: this is fine for testing, but we need to be careful that we revert or fix this before we merge.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed dependencies.

@@ -3941,6 +3941,223 @@
}
}
},
"@google-cloud/dialogflow-cx": {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't these modules be listed in package.json?

@ear-dev ear-dev requested a review from Shailesh351 February 11, 2022 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants