-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add Action Plugin - Virpil LED Control #354
base: develop
Are you sure you want to change the base?
Conversation
You can select the Device, Command and the color with an Color Picker
That is tip top for my alphas. Gonna merge that in my branch. Love the idea to turn the joystick red is case of heavy damages or yellow once hardpoints are deployed in Elite Dangerous by parsing the log journal ! |
This looks really neat, two things I'd change:
The bigger issue is that while I can merge it, this code is likely never going to see a release. The reason is that I will only create a new release once R14 is ready. However, that has a different way in which the UI is done as it uses QML instead of raw Qt. So I would have to remove the plugin again as I won't be able to test it out when porting the UI component of it. The good part though is that the UI itself should be rather simple to create once R14 gets closer to being done and the logic of setting the LEDs would stay the same. |
Thanks @WhiteMagic for JG and @dasTholo for this great extension. Really useful. Just started using it with the CM3 Throttle. Keen to support this going forward. Will be happy to test etc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I´ve rewrite the Colorpicker to a Combolist, because the Virpil will only support a few Colors.
As R14 will require a complete rewrite of all UI components this action won't be merged as there will be no R13 code-branch releases anymore. However, this PR still allows others to try this out. |
I will definitely be giving this a try. Much more elegant than the VPC_LEDs plugin I've been using... far less limiting to be able to assign a state change to a specific action rather than to a physical button from the plugin tab. Thanks for this man! |
You can select the Devices, Command and the color with an Color Picker.
quick test video
Maybe I should create a file picker that takes the selection of "vpc_led_control.exe" to the virpil software suite.
Big Thanks to Whitemagic for this work! His code has inspired me