-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve performance and bundle size #537
base: main
Are you sure you want to change the base?
Improve performance and bundle size #537
Conversation
reduced bundle size using dynamic imports.
removed wallet icons to use external assets, this should reduce the bundle size.
✅ Deploy Preview for exquisite-salamander-a1fe5e ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
…studio/white-whale-frontend into DavideSegullo/improve-performance
Hola @nick134-bit, sorry to bother you, as I would like to add more enhancements, this PR is ready for review. When you can, could I get some feedback? Thank you! |
Hey @DavideSegullo, |
Hola @nick134-bit thank you for your message, I understand the risks and doubts in changing the wallet manager, yes I saw that there were custom logics build on cosmos-kit, but most of these can be removed as they are already handled, so this would help simplify the code. Reducing the bundle size is not the only benefit of course, for example:
About the issue regarding ledger support, it doesn't refer to ledger support in wallets, those work on keplr etc., it refers to the ability to directly connect the ledger to the app without going through any wallet to sign a tx via USB connection. Regarding wallets, terra station at the moment is totally supported even on chains other than terra2 (I did several tests on juno signed tx for cosmwasm), the only thing they don't allow you to do at the moment is to sign tx with direct sign. The wallets are maintained publicly on PR by those who suggest new additions and from quirks team, via discord or github if anyone want support to integrate some wallet that is missing we are available, but also by staying up to date as much as possible with cosmos wallet registry |
Description and Motivation
This PR aims to improve the performance of the app and the overall experience:
TODO after this PR:
Bundle size compare
Before:
After:
The impact on bundle size has been reduced by 9x, but I aim to reduce it again, you can go down further
Checklist:
Update index.md
)yarn lint
.yarn build
.