Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add correct ibctransfer stack #272

Merged
merged 1 commit into from
Nov 6, 2023
Merged

Add correct ibctransfer stack #272

merged 1 commit into from
Nov 6, 2023

Conversation

expertdicer
Copy link
Contributor

Description and Motivation

Related Issues

Checklist:

  • I have read Migaloo's contribution guidelines.
  • My pull request has a sound title and description (not something vague like Update index.md)
  • All existing and new tests are passing.
  • I updated/added relevant documentation.
  • The code is formatted properly golangci-lint run ./... --fix.

catShaark
catShaark reviewed Nov 6, 2023
View reviewed changes
Copy link
Contributor

@catShaark catShaark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems more likely to be the solution than re-ordering the transfer stack. Once tested, we can get this merged

@Sen-Com Sen-Com merged commit d8c41e2 into release/v3.0.x Nov 6, 2023
14 of 15 checks passed
@hoank101 hoank101 deleted the nguyen/fix-ibc-stack branch March 22, 2024 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@catShaark catShaark catShaark approved these changes

@PolkachuIntern PolkachuIntern Awaiting requested review from PolkachuIntern

@faddat faddat Awaiting requested review from faddat faddat is a code owner

@Sen-Com Sen-Com Awaiting requested review from Sen-Com Sen-Com is a code owner

@kerber0x kerber0x Awaiting requested review from kerber0x kerber0x is a code owner

@0xFable 0xFable Awaiting requested review from 0xFable 0xFable is a code owner

@vuong177 vuong177 Awaiting requested review from vuong177

@hieuvubk hieuvubk Awaiting requested review from hieuvubk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@expertdicer @catShaark @Sen-Com