clean up: overloadedSpecDomainCheck is always on

Summary:
- as title
- moving overloaded_specs_union.erl from options to check test project
- regenerating snapshot outputs, which triggers a few more type errors

Reviewed By: michalmuskala, TD5

Differential Revision: D65595959

fbshipit-source-id: 2570d414973cd52be6c79d58a2f3186dd71c0dae

eqwalizer/src/main/resources/application.conf

@@ -16,8 +16,6 @@ eqwalizer {
     custom_maps_merge = ${?EQWALIZER_CUSTOM_MAPS_MERGE}
     ignored_overloaded_spec = false
     ignored_overloaded_spec = ${?EQWALIZER_IGNORED_OVERLOADED_SPEC}
-    overloaded_spec_domain_check = true
-    overloaded_spec_domain_check = ${?EQWALIZER_OVERLOADED_SPEC_DOMAIN_CHECK}
     report_dynamic_lambdas = false
     report_dynamic_lambdas = ${?EQWALIZER_REPORT_DYNAMIC_LAMBDAS}
 }

eqwalizer/src/main/scala/com/whatsapp/eqwalizer/package.scala

@@ -38,7 +38,6 @@ package object eqwalizer {
       mode: Mode.Mode,
       errorDepth: Int,
       ignoredOverloadedSpec: Boolean,
-      overloadedSpecDomainCheck: Boolean,
       reportDynamicLambdas: Boolean,
   )
 
@@ -56,7 +55,6 @@ package object eqwalizer {
       mode,
       errorDepth = config.getInt("error_depth"),
       ignoredOverloadedSpec = config.getBoolean("ignored_overloaded_spec"),
-      overloadedSpecDomainCheck = config.getBoolean("overloaded_spec_domain_check"),
       reportDynamicLambdas = config.getBoolean("report_dynamic_lambdas"),
     )
   }

eqwalizer/src/main/scala/com/whatsapp/eqwalizer/tc/ElabApplyOverloaded.scala

@@ -33,8 +33,7 @@ class ElabApplyOverloaded(pipelineContext: PipelineContext) {
       case _ =>
         if (pipelineCtx.overloadedSpecDynamicResult && typeInfo.isCollect)
           diagnosticsInfo.add(NoSpecialType(expr.pos, expr, argTys))
-        if (pipelineContext.overloadedSpecDomainCheck)
-          toFunType(depFunSpec).foreach(ft => elabApply.elabApply(check.freshen(ft), args, argTys, env1))
+        toFunType(depFunSpec).foreach(ft => elabApply.elabApply(check.freshen(ft), args, argTys, env1))
         (DynamicType, env1)
     }
   }

eqwalizer/src/main/scala/com/whatsapp/eqwalizer/tc/package.scala

@@ -70,7 +70,6 @@ package object tc {
     val overloadedSpecDynamicResult: Boolean = config.overloadedSpecDynamicResult
     val customMapsMerge: Boolean = config.customMapsMerge
     val ignoredOverloadedSpec: Boolean = config.ignoredOverloadedSpec
-    val overloadedSpecDomainCheck: Boolean = config.overloadedSpecDomainCheck
     val reportDynamicLambdas: Boolean = config.reportDynamicLambdas
   }
 }